search

eProsima / foonathan_memory_vendor

foonathan/memory vendor package for Fast DDS. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
23 stars 47 forks source link

Update vendor package Quality Declaration to QL3. #35

Closed hidmic closed 4 years ago

hidmic commented 4 years ago

Precisely what the title says.

nuclearsandwich commented 4 years ago

As far as I can see, nothing has changed about foonathan_memory_vendor since the QD was last updated, but it was previously meeting the QL3 criteria and this update reflects that?

hidmic commented 4 years ago

As far as I can see, nothing has changed about foonathan_memory_vendor since the QD was last updated, but it was previously meeting the QL3 criteria and this update reflects that?

AFAIU that is correct. A QL3 package can have a >QL3 dependency as per REP-2004.

nuclearsandwich commented 4 years ago

A QL3 package can have a >QL3 dependency as per REP-2004.

I'm either confused about what the dependency relationship has to do with the change or I'm mistaken about the effect of this PR.

hidmic commented 4 years ago

I'm either confused about what the dependency relationship has to do with the change or I'm mistaken about the effect of this PR.

Probably didn't provide enough information. My bad.

The foonathan_memory_vendor package is already QL3 according to REP-2004. I presume it was not marked as such before this patch either due to a misunderstanding about the requirements on its dependencies or, most likely, an omission.

Your initial assesment:

nothing has changed about foonathan_memory_vendor since the QD was last updated, but it was previously meeting the QL3 criteria and this update reflects that?

is correct.

nuclearsandwich commented 4 years ago

Appreciate the clarification. That all makes sense to me.

nuclearsandwich commented 4 years ago

Since this is a documentation-only change I don't see a need for CI.