search

eProsima / foonathan_memory_vendor

foonathan/memory vendor package for Fast DDS. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
23 stars 47 forks source link

Build as static by default [13951] #58

Closed EduPonz closed 2 years ago

EduPonz commented 2 years ago

Upstream is not exporting some symbols when building a dynamic library, which leads to linking errors on Windows platforms. This PR sets the vendor to build memory as a static library with position independent code as default, letting the user configure both BUILD_SHARED_LIBS and CMAKE_POSITION_INDEPENDENT_CODE as CMake options. Once memory is ready to be built as a DLL, then we can consider changing the default value for BUILD_SHARED_LIBS

EduPonz commented 2 years ago

CI run: