Closed joereddington closed 1 year ago
Deployed IMPS3 to server and, and part of this. Fixed some bugs.
I should be using a development branch for exactly this reason. I should also update the php on the AWS server. I'll wait until a week without camps.
Updating IMPS3 but can't work out why the php isn't doing the thing.
Tests for IMPS3 are taking around 46 seconds.
I added setup and tear down code to make things a little easier to see. These are the worst offenders.
2.480 : test_etherpad.TestEverpad.test_download_all_books_that_start_with_slug 4.597 : test_chapter.TestChapter.test_writeoutputfilesWithCharacter 4.653 : test_chapter.TestChapter.test_populate_book_from_slug 4.666 : test_chapter.TestChapter.test_get_latex 4.666 : test_etherpad.TestEverpad.test_get_ordering 4.699 : test_bookdatabase.TestBookdatabase.test_cast_object_coming_out_of_database 4.704 : test_chapter.TestChapter.test_regress_latex 5.072 : test_bookdatabase.TestBookdatabase.test_add_book_to_database 5.226 : test_chapter.TestChapter.test_writeoutputfilesWithUnknownCharacter ~
It appears that at least one major offender is the singleton book code. It takes 5 seconds to get the book. I'd like it to work better by which I mean: I need it to work from the local database.
Check out these command lines:
git add --patch test_chapter.py
git stash pop git stash push -m "making singletonbook faster" git status
Next action is to examine the test for casting the file properly.
There's been a lot of refactoring and I'm reasonably happy that the code is in better shape.
Some quick notes from being on a camp today
Piloting the next version of IMPS3 is taking a while so let's look into the list of features I wanted to build in the previous issue.
Sprint 1
Sprint 2
Sprint 3
Sprint 4