Closed blaise17 closed 5 years ago
This is looking great! I'm loving some of the patterns we are creating and using. I think it's probably worth creating some follow on tickets for this work;
- Test behaviour on a windows touch device
Totally
- Sort out some of the drag/selection issues
Yeah, they're pesky
- I'm sure there was another one, but I've forgotten what it was
That's okay, it'll come to you
- Oh! I remember; implement the same optional behaviours on other buttons (the speechbar buttons)
Bwah hah hah! Look again! Already done!
I had no idea you could reply to comments inline!
Tested and works :) Small caveat: If I have it set to trigger on release, then I feel like I should be able to press on "A" move the cursor and release on "B" to input "B". That's not what this does, I need to check what other devices do I think before I come down on if that's a problem behaviour.
That's what it's supposed to do (as long as you're on release, not click)... and what it does on laptops in chrome... what are you testing on?
EDIT: Just tried in firefox and it fires the release event as though you haven't moved! I'll see what it's doing and fix it, that's not acceptable
Per phone call - I'm find with a 'works but not on firefox' solution as long as the major mobile browsers are fine :)
Totally
Yeah, they're pesky
That's okay, it'll come to you
Bwah hah hah! Look again! Already done!