search

eQualityTime / ovfplayer

The Open Voice Factory - open software for people with communication difficulties
GNU General Public License v3.0
2 stars 1 forks source link

Clare/issue#98/symbol set schema support #140

Closed blaise17 closed 5 years ago

blaise17 commented 5 years ago

Don't explode if a symbol set is used for an image, just gracefully don't display it as we don't have them.

joereddington commented 5 years ago

Is there a handy 'failing' test file I can use to check?

blaise17 commented 5 years ago

If you mean a test file that has a symbol set in, then yes. test/fixtures/obz/symbolset.obz It is the test file used in the test I added to test this.

joereddington-public commented 5 years ago

Okay, tested with https://joereddington-public.github.io/testobz/symbolset.obz - the behavour I got was "ignore new file and gracefully display the default file rather than the last sucessfully loaded" - do we want that behaviour? (I also feel like I want an error message, even as an alert, just telling the person in the config what's happening...)

blaise17 commented 5 years ago

You're supposed to be getting the file you asked for but with no image on the one that we don't have a symbol set for... And when I load that link as my board in my config, on my branch, I get that board loaded... Are there any errors? Are you definitely running this branch?

joereddington-public commented 5 years ago

I am foolish. I hadn't noticed that the default file didn't have many images on it... I approve this.