search

eQualityTime / ovfplayer

The Open Voice Factory - open software for people with communication difficulties
GNU General Public License v3.0
2 stars 1 forks source link

Review comments #146

Closed psi77 closed 5 years ago

psi77 commented 5 years ago

Addressing some review comments; change method name disable back button if no stack present

psi77 commented 5 years ago

Approve-with-query: should the arrow on the back button also be greyed out?

@blaise17 what do you think?

blaise17 commented 5 years ago

Approve-with-query: should the arrow on the back button also be greyed out?

@blaise17 what do you think?

I think it should be consistent with the other buttons being disabled. Currently I believe only the speak button gets disabled and its appearance is consistent with the back button. Potentially we should disabled backspace and clear when there are no items in the speechbar... but that's largely irrelevant. Potentially we should change the disabled behaviour to grey out the icons, but that would be another ticket. Do you want to raise it @joereddington ?

joereddington commented 5 years ago

I'm happy not to raise it just yet. Looks good!