search

eReuse / devicehub-teal

New devicehub
GNU Affero General Public License v3.0
17 stars 12 forks source link

Suggest to loosen the dependency on boltons #418

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Dear developers,

Your project devicehub-teal requires "boltons==18.0.1" in its dependency. After analyzing the source code, we found that the following versions of boltons can also be suitable without affecting your project, i.e., boltons 17.2.0, 18.0.0. Therefore, we suggest to loosen the dependency on boltons from "boltons==18.0.1" to "boltons>=17.2.0,<=18.0.1" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on boltons?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?


Details:

Your project (commit id: 63d99998a21337b5fe6103c733ae0e73e9a2a91f) directly uses 4 APIs from package boltons.

boltons.urlutils.URL.normalize, boltons.typeutils.classproperty.__init__, boltons.urlutils.URL.to_text, boltons.urlutils.URL.__init__

Beginning fromwhich, 22 functions are then indirectly called, including 12 boltons's internal APIs and 10 outsider APIs as follows:

[/eReuse/devicehub-teal]
+--boltons.urlutils.URL.normalize
|      +--boltons.urlutils.resolve_path_parts
+--boltons.typeutils.classproperty.__init__
+--boltons.urlutils.URL.to_text
|      +--boltons.urlutils.quote_path_part
|      |      +--unicodedata.normalize
|      |      +--boltons.urlutils.to_unicode
|      +--boltons.urlutils.URL.get_authority
|      |      +--boltons.urlutils.quote_userinfo_part
|      |      |      +--unicodedata.normalize
|      |      |      +--boltons.urlutils.to_unicode
|      +--boltons.urlutils.quote_fragment_part
|      |      +--unicodedata.normalize
|      |      +--boltons.urlutils.to_unicode
+--boltons.urlutils.URL.__init__
|      +--boltons.urlutils.parse_url
|      |      +--boltons.urlutils.URLParseError.__init__
|      |      +--boltons.urlutils.parse_host
|      |      |      +--boltons.urlutils.inet_pton
|      |      |      |      +--boltons.urlutils._sockaddr.__init__
|      |      |      |      +--ctypes.c_int
|      |      |      |      +--ctypes.sizeof
|      |      |      |      +--socket.error
|      |      |      |      +--ctypes.byref
|      |      |      |      +--ctypes.FormatError
|      |      |      |      +--ctypes.string_at
|      |      |      +--socket.inet_pton
|      |      |      +--boltons.urlutils.URLParseError.__init__
|      +--boltons.urlutils.URLParseError.__init__
|      +--boltons.urlutils.unquote
|      |      +--boltons.urlutils.unquote_to_bytes
|      |      |      +--string.encode
|      |      |      +--string.split

Since all these functions have not been changed between any version for package "boltons" from [17.2.0, 18.0.0] and 18.0.1. Therefore, we believe it is safe to loosen the corresponding dependency.