search

eReuse / workbench

The eReuse.org Workbench is a toolset to assist with the diagnostic, benchmarking, inventory and installation of computers.
https://www.ereuse.org
GNU Affero General Public License v3.0
13 stars 7 forks source link

Wrong unit values #50

Closed bustawin closed 7 years ago

bustawin commented 7 years ago

DDI can sometimes generate wrong unit sizes (ex. setting a value in MB when GB is required), like in this JSON with the size of the hard-drive, and I remember cases with the speed of the CPU (being thousands of Ghz) . See here, at the bottom of the page (last paragraph), the schema with the unit sizes DeviceHub waits for.

In old versions of DDI (prior 7.0) they used LSHW to know the unit size, although sometimes this request returns None. DDI can use too some guessing: if a Hard drive has a size of >1000 is probably going to be in MB not in GB; the same for a clock speed of >10 for a Processor.

ivilata commented 7 years ago

@bustawin Hmmm, here I see (under "Response JSON Object") this:

size (float) – Unit Code: mbyte (4L)

In the sample JSON file I see:

        {
            "@type": "HardDrive", 
            […]
            "size": 152627.8359375, 
            […]
        },

That would be a 150 GB drive, which makes sense to me. Maybe MB are required actually?

bustawin commented 7 years ago

@ivilata totally right, I do not know what I saw :-)