search

eReuse / workbench

The eReuse.org Workbench is a toolset to assist with the diagnostic, benchmarking, inventory and installation of computers.
https://www.ereuse.org
GNU Affero General Public License v3.0
13 stars 7 forks source link

Use the labelId for the name of the JSON #56

Open bustawin opened 7 years ago

bustawin commented 7 years ago

It is more useful to have the model name plus with the id of the label for the name of the JSON, making it easier to manage when creating labels, rather than the serial number (which could be a fallback if the label does not exist).

fileName = modelName + '-' + labelId

ivilata commented 7 years ago

Commit bb9e7ac7 uses the label if given, otherwise the previous nomenclature.

I'm not sure about including the model name, it may be too verbose. In any case I'd include the model after the label/serial so that the differentiating part comes first. What do you think?

ivilata commented 7 years ago

Assigning to @bustawin for feedback.

bustawin commented 7 years ago

@ivilata Organizations usually perform batches of computers of the same model, so if they have the model first and they order the files by name... you can see the point

ivilata commented 7 years ago

Yeah, it makes sense. Commit 989ae3b5 uses manufacturer,model,label-or-serial.json instead.