eReuse / workbench

The eReuse.org Workbench is a toolset to assist with the diagnostic, benchmarking, inventory and installation of computers.
https://www.ereuse.org
GNU Affero General Public License v3.0
13 stars 7 forks source link

Hangs waiting for SMART test, bad error return #58

Closed ivilata closed 7 years ago

ivilata commented 7 years ago

In some computers, the step of SMART test hangs after the progress bar reaches its end. If the process is interrupted with Ctrl+C, it reveals that it's sitting on the time.sleep(5) at the end of the while remaining > 0 loop in benchmark.py:hard_disk_smart().

A similar hang was fixed in commit ea0c79f0, however the fix may not be correct or complete.

Also, the returned error field may be null instead of a boolean.