search

eSAMTrade / retry

easy to use retry decorator in python
Other
28 stars 9 forks source link

Change logger.warning input to string to adapt all logger (eg. loguru) #2

Closed DachuanZhao closed 2 years ago

asuiu commented 2 years ago

I will have to reject this PR due to the lack of content - it doesn't bring any new functionality to the code, and doesn't improve it.

DachuanZhao commented 2 years ago

I will have to reject this PR due to the lack of content - it doesn't bring any new functionality to the code, and doesn't improve it.

I have created an example in colab . As you can see , the logger doesn't work because its parameter isn't a str . This is why I push this PR .

asuiu commented 2 years ago

Hi @DachuanZhao , unfortunately I wasn't notified on the comments on closed task, so my answer comes quite late. Yes, I see now what was the reason for this PR, and with these information - I would have merged it. Next time I will ask more questions before closing. The same change was made here https://github.com/eSAMTrade/retry/pull/3 , and it was properly justified, so I've merged it. Sorry I didn't come back on this in time, probably next time is better to open a new/issue for visibility or notify me explicitly.

Thank you for your contribution!