search

eScholarship / jschol

Other
10 stars 13 forks source link

PUBD-1313 Display HTML markup in requested fields #690

Closed hardyoyo closed 5 months ago

hardyoyo commented 5 months ago
hardyoyo commented 5 months ago

a nice backgrounder of terser vs. other minifiers (like uglify): https://blog.logrocket.com/terser-vs-uglify-vs-babel-minify-comparing-javascript-minifiers/

The TLDR of commit 765ad32 is this: uglify didn't zig with the zags, was still expecting md5 out of terser (which uglify uses under the hood)... terser kept up with Node... so... just using terser alone gets us minification, where trying to use uglify gets us this error:

ERROR in app-bundle-1effd3cc50ea4d27ec9c.js from Terser
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:69:19)
    at Object.createHash (node:crypto:133:10)
    at /Users/hpotting/workspace/jschol/node_modules/terser-webpack-plugin/dist/index.js:217:37