search

eWAYPayment / eway-rapid-php

Eway Rapid PHP library
https://www.eway.com.au
MIT License
14 stars 24 forks source link

Transaction model missing attributes in phpdoc #22

Open OldStarchy opened 3 years ago

OldStarchy commented 3 years ago

There are a bunch of attributes on the Transaction model missing from the phpdoc, namely TransactionStatus referenced by the docs and used in the readme example.

This left me confused for a while before I decided to check the code to make sure it wasn't just a typing problem; it wouldn't be the first time that the documentation for an API is out of sync with either the client library or the implementation (or both).

The following phpdoc properties are missing

Address
AuthorisationCode
BeagleEmail
BeaglePhone
BeagleScore
BeagleVerification
Captured
CustomerIP
CustomerNote
CustomerReadOnly
CustomView
CVN
Email
HeaderText
InvoiceReference
Language
LogoUrl
Mobile
Phone
ProcessingDetails
ResponseCode
ResponseMessage
Status
Total
TotalAmount
TransactionID
TransactionStatus
Verification
VerifyCustomerEmail
VerifyCustomerPhone

Also, AuthorisationCode is listed in $fillable twice.

OldStarchy commented 3 years ago

(Semi) related https://github.com/eWAYPayment/eway-rapid-php/pull/4