search

eWaterCycle / ewatercycle-lisflood

eWaterCycle plugin for LISFLOOD hydrological model
Apache License 2.0
1 stars 1 forks source link

Rewrite lisflood model tests #1

Open sverhoeven opened 1 year ago

sverhoeven commented 1 year ago

The download of parameter set (https://github.com/ec-jrc/lisflood-usecases/archive/refs/heads/master.zip) can take a long time (> 4 minutes) as it downloads over 500Mb and is throttled. We should make it quicker by creating a fake parameter set and forcing.

In https://github.com/eWaterCycle/ewatercycle/pull/365/commits/aa38d0dbbac1da033d0824a984e5cdba7156ac78 the tests where marked as skipped. This improved CI from 24 minutes to less than 8 minutes.

BSchilperoort commented 1 year ago

Was this fixed in dbfe5a8b871fcce290aea7ef487bdd26efd353bd ?

sverhoeven commented 1 year ago

CI seems to run quick <4min, which is ok.

We should remove the TODO at https://github.com/eWaterCycle/ewatercycle-lisflood/blob/d43fe44321c468a48d7d01db3894b990517b7607/tests/test_model.py#L43 to make this issue fixed.