lisflood generate forcing needs an argument to run lisvap

eWaterCycle / ewatercycle-lisflood

eWaterCycle plugin for LISFLOOD hydrological model

Apache License 2.0

1 stars 1 forks source link

lisflood generate forcing needs an argument to run lisvap #11

Open SarahAlidoost opened 2 years ago

SarahAlidoost commented 2 years ago

The current LisfloodForcing returns an error due to the lisvap output. The generate function needs a boolean argument to ask whether lisvap should be run.

SarahAlidoost commented 2 years ago

so, when for example run_lisvap = False, Lisflood forcing should return none for lisvap output. Therefore, the default values for those outputs should be removed from init.

SarahAlidoost commented 2 years ago

The first comment is addressed in PR eWaterCycle/ewatercycle#163. The second comment needs more design sessions when addressing issue eWaterCycle/ewatercycle#96.