Use public use case in lisflood notebook

eWaterCycle / ewatercycle-lisflood

eWaterCycle plugin for LISFLOOD hydrological model

Apache License 2.0

1 stars 1 forks source link

Use public use case in lisflood notebook #12

Open sverhoeven opened 3 years ago

sverhoeven commented 3 years ago

The https://github.com/eWaterCycle/ewatercycle/blob/master/examples/lisflood.ipynb uses a private parameter set. This makes it impossible for other users to run the notebook. Can we change the notebook to use Use case 1: Fraser River, British Columbia, Canada?

SarahAlidoost commented 3 years ago

Our lisflood version isnot compatible with the existing lisflood use cases . Also, there is no other public parameters. One way to fix this issue is to create a new use case based on the private parameter set. However, there are some considerations:

private parameterset is not calibrated completely and published yet,
whether lisflood works with a non-global dataset.

sverhoeven commented 3 years ago

I see the https://github.com/ec-jrc/lisflood-usecases repo made some changes last year to make it work with lisflood v3.0.0 . Could we try to find an older commit that does work with our Docker image?