eWaterCycle / ewatercycle

Python package for running hydrological models
https://ewatercycle.readthedocs.io/en/latest/
Apache License 2.0
35 stars 5 forks source link

Premade forcings in a configured directory #248

Open sverhoeven opened 3 years ago

sverhoeven commented 3 years ago

We have prepared several forcings for use in example notebooks. It would be nice if we could have a central location where those forcing could be read from. Similar to parameter set it would be nice if I could do

import ewatercycle.forcing
ewatercycle.forcing.available_forcings()
[
'marrmot-m01_example_1989-1992_buffalo-river', 
 'marrmot-m01_ERA5_1990-2001_savannah', 
 'wflow_ERA5_1990-2001_merrimack'
]
forcing = ewatercycle.forcing.load('marrmot-m01_ERA5_1990-2001_savannah')
model = MarrmotM01('2020.11', forcing)

I expect ewatercycle.forcing.load() method when given a relative path to look in current working directory and if not there also check in CFG['forcing_root_dir']

The ewatercycle.yaml could have following key/value:

forcing_root_dir: /mnt/data/forcing

It could be nice to have multiple forcing_root_dir directories to organize things better.

sverhoeven commented 3 years ago

Now in the experiment launcher a root dir is appended, with it configured in the eWatercycle python package I dont have to do that anymore.

Peter9192 commented 3 years ago

We might want to think about the permissions for this forcing dir, though. I see a few options: