search

eWaterCycle / ewatercycle

Python package for running hydrological models
https://ewatercycle.readthedocs.io/en/latest/
Apache License 2.0
35 stars 5 forks source link

`model.setup` return type for `cfg_file` should match `model.initialize` input type #52

Closed Peter9192 closed 3 years ago

Peter9192 commented 3 years ago

According to pymt, you should be able to do

cfg_file, cfg_dir = model.setup(...)
model.initialize(cfg_file)

This currently doesn't work as setup return a Path, whereas initialize expects a str. I think we should make setup return a str.

SarahAlidoost commented 3 years ago

steup should get cfg_dir as a string too.