Open sverhoeven opened 7 months ago
Very cool stuff! I managed to start up a local infra with vagrant and become my own teacher 😎 Approving as it works and is ready to use, but you may still consider the few comments I had at your own discretion.
- As a student I don't have permission to see the contents of /var/local/nbgrader/exchange/course1/inbound/, as a teacher I do. This seems good.
:)
- As a student, I am able to open the formgrader, which, even if it's not a problem, I found confusing, to say the least.
- As a student, I also have the right hand side tab to "create assignment", which doesn't really make sense either, or does it?
When I run the https://github.com/eWaterCycle/teaching/tree/stefan-trials/demo#jupyterhub example then the student1 account only has Assignment list
in nbgrader menu. Will give it a try
- Have you considered moving all the teaching-specific config from README.md to TEACH.md?
Moved teaching stuff to README.md and USER.md
disabling nbgrader.formgrader gives 404, but menu still has formgrader.
disabling nbgrader.formgrader gives 404, but menu still has formgrader.
Disable extensions per user seems to have worked.
Setup seems to work for the lesson development. Hopefully also when the students access it :crossed_fingers:
We discussed limiting the students on their memory & cpu use to reduce the chance of a single student locking up a server. That could still be nice to add.
For testing locally please upgrade vagrant to latest version.
Uses https://github.com/eWaterCycle/teaching/tree/nbgrader-quickstart as course material source.
This PR also includes some linting and deprecation fixes.