search

eWert-Online / OSnap

OSnap is a snapshot testing tool, which mainly focuses on speed and ease of use.
https://ewert-online.github.io/OSnap/
152 stars 2 forks source link

Name of snapshot directory wrong #26

Closed ntzrbtr closed 1 year ago

ntzrbtr commented 1 year ago

If I set the "snapshotDirectory" to "./snapshots/live/", the created folder is "osnap./snapshots/live/", so it adds the dot to the generated folder name instead of taking it as marking a relative path. Also, why is "osnap" always added to the front of the snapshot path, this is not in the docs?

eWert-Online commented 1 year ago

Hi @ntzrbtr

thank you for reporting the issue. That should definetly not be the case.

It would be good to know which operating system you are using and if you are running osnap inside docker (if so which docker image are you using).

Would it be possible for you to create a small reproduction case and push it into a public repository?

ntzrbtr commented 1 year ago

I've set up a test repo under https://github.com/ntzrbtr/osnap-test. I included the snapshot folder generated so you can see the directory structure.

I've used OSnap on my M1 Mac directly, not with the Docker image.

eWert-Online commented 1 year ago

Awesome thank you! I will look into it (probably) this weekend 🙂

eWert-Online commented 1 year ago

@ntzrbtr I could identify the issue(s) and a fix for #26 and #27 is deployed in the latest @nightly tag. To test it, you can install osnap in version ^1.5.0-nightly.d8a46a.

Could you confirm, that the issues are resolved for you?

ntzrbtr commented 1 year ago

It works now, thanks for the update!