search

eXaminator / kanka-foundry

FoundryVTT module to import information from kanka.io
MIT License
22 stars 8 forks source link

New Kanka journal options? #127

Closed Nedrapter closed 3 months ago

Nedrapter commented 7 months ago

So I'm noticing when I create a new journal there are some new Kanka related options. I attempted to create one to experiment and I got those errors in the console and the journal was just a normal empty journal. image

image What exactly are these new options supposed to do? All of them give similar errors like the above when I try to create them and open a normal empty journal page.

eXaminator commented 7 months ago

I changed the journals to use the "new" page system of foundry instead of a completely custom layout. For that to work I have to register my custom page sheets. Sky, this also makes the available for users to select when creating their own journals. But that doesn't work, because your custom page does not have the necessary data model and I don't provide forms to edit them (because that's not what they are meant for).

Ideally foundry would allow me to hide these pages. Maybe I'll investigate a way to do that manually to reduce confusion, albeit at the price of potentially breaking interoperability with some other modules. At the very least I could at something like "don't use" to the names and add an info to the readme.

I think I should also open a foundry issue for that.

Nedrapter commented 7 months ago

Understood. Yea I was bit confused with all these new options.