Closed anthonyscorrea closed 2 years ago
Good point, thanks for the issue.
I'll have to think about this for a while, since the code above is generated in webpack (in the file-loader, to be more precise). Usually you have to define the base path at build time, but that's not possible here. I'll have to come up with something.
I could get far enough as to find the line where and why the issue presents itself, but I’m not savvy enough to figure out how to fix it.
I noticed this problem in another module (ff-star-wars-enhancements) and saw it can be fixed by changing /modules/ffg-star-wars-enhancements/fonts/NewsCycle-Regular.ttf
to ../fonts/NewsCycle-Regular.ttf
Maybe having the relative link with ..
instead of the module location will be easier than whatever fix first popped into mind.
:tada: This issue has been resolved in version 2.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Thank you!
Module does not taken into account routePrefix. The module works as intended, except the image to the kanka logo does route to the right location.
I believe the offender is in this line of code:
Prior to l.p, a routePrefix should be there if it exists in the configuration.