eXaminator / kanka-foundry

FoundryVTT module to import information from kanka.io
MIT License
22 stars 8 forks source link

Does not use routePrefix #78

Closed anthonyscorrea closed 2 years ago

anthonyscorrea commented 2 years ago

Module does not taken into account routePrefix. The module works as intended, except the image to the kanka logo does route to the right location.

I believe the offender is in this line of code:

            7308: (r, a, l) => {
                r.exports = l.p + "assets/kanka.png"
            },

Prior to l.p, a routePrefix should be there if it exists in the configuration.

eXaminator commented 2 years ago

Good point, thanks for the issue.

I'll have to think about this for a while, since the code above is generated in webpack (in the file-loader, to be more precise). Usually you have to define the base path at build time, but that's not possible here. I'll have to come up with something.

anthonyscorrea commented 2 years ago

I could get far enough as to find the line where and why the issue presents itself, but I’m not savvy enough to figure out how to fix it.

I noticed this problem in another module (ff-star-wars-enhancements) and saw it can be fixed by changing /modules/ffg-star-wars-enhancements/fonts/NewsCycle-Regular.ttf to ../fonts/NewsCycle-Regular.ttf

Maybe having the relative link with .. instead of the module location will be easier than whatever fix first popped into mind.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

anthonyscorrea commented 2 years ago

Thank you!