search

eXaminator / kanka-foundry

FoundryVTT module to import information from kanka.io
MIT License
22 stars 8 forks source link

Updates for v9 #86

Closed crimsonknave closed 2 years ago

crimsonknave commented 2 years ago

I did a little poking around and it appears that data-type="JournalEntry" and class="entity-link content-link" are required. Once I added those manually to one of the elements it was clickable. (I poked at the regular journal entries to see what the difference was).

classes = 'entity-link content-link', also works, but entity-link is used in a number of styles, so I left it in for now.

I'm unsure how to test the changes in this PR to ensure I got it everywhere, but from my quick look in the code base, this seems like the right place.

Fixes #85 (I think)

eXaminator commented 2 years ago

Thanks a lot! Sadly I won't be able to test this for another week. I'll see if I can get it merged at the end of next week.

eXaminator commented 2 years ago

I decided to go with a (hopefully) slightly more future proof fix for this where I don't want to build the link myself (but let Foundry handle it). So I'm not going to merge this.

But I still really appreciate you creating a PR! Thank you very much.

My fix will probably be released today after I looked into a few other changes I might want to make.