Closed grantmacken closed 6 years ago
I'll have a crack, at branching in the dockerfile, after the weekend.
It looks like this is missing some commits in comparison to https://github.com/eXist-db/docker-existdb/pull/22 ?
I am closing this, pull request. It is getting out of sync with the merged #22 and it actually extends code from that merge. I will raise a new issue, and create a branch from develop
It is pull-request from master as requested by @duncdrum in #20
The Dockerfile can build images based on 2 build args.
branch name
e.g release, develop, xx-feature-branchtagged commit
e.g. eXist-4.3.1commit hash
( short or long ) e.g 3b19579, 3b195797a2c2f35913891412859b06d94f189229NOTE: the docker build args VERSION, BUILD_DATE, VCS_REF are created via a dockerhub build hook hooks/build
Neither VERSION or BRANCH or required. If build-arg VERSION is empty, then the image is built from from the build-arg BUILD If build-arg BRANCH is empty then image defaults to the develop branch
This is a rework of the Dockerfile to build from openjdk-slim. It also tries to collapse the process logic in build.sh into the Dockerfile The only thing I had trouble with was copying over the webapp files I've commented out what I tried, and just copied over the whole webapp dir instead. I think I got it all, but there might be stuff I've missed
I created a config dir, moved known config files into it, and symlinked to back to origin. This allows the user to have a persistent docker volume consisting of eXist configuration files. See the docker-compose file for an example run-time declaration.
Dockerfile - modifications
hooks/build
docker-compose.yml - mods
,env - addition
docker-compose.yml
Readme