Closed duncdrum closed 5 years ago
bats always run in sequence, splitting the tests like this makes it easier to see where stuff breaks imv, otherwise we d have multiple steps in one @test
(like the teardowns) which tends to hide relevant test output from the logs
also nesting is not an option, which I would have preferred.
@grantmacken great, thanks for the review. i m a bit hesitant about using compose for testing as it modifies the containers behaviour, and my primary goal is to make sure that the standalone container is running properly. There is also the fact that docker-compose the library adds another dependency. But I'll gladly take a look at what you come up with.
refactored our ci config and test setup. Build images in parallel, and use bats to execute unit test. The main motivation was the lack of information given the recent breakage, while not much of a speed improvement it also introduces the ability to run tests locally, and should make debugging simpler moving forward.
Currently the test for any Errors in the logs is skipped, we're still not there yet.