search

eXist-db / docker-existdb

Docker image builder for eXist-db
GNU Affero General Public License v3.0
11 stars 6 forks source link

Green hotfix #64

Closed duncdrum closed 5 years ago

duncdrum commented 5 years ago

This uses shallow clones depth=1 in the builder stage for branch and tag based builds, which makes them faster, leads to less congested airwaves, and about 600mb smaller builder images on disk.

commit based builds are depth=2000 which is i think the maximum of what we can sensibly expect to work and still better than having 14000 commits and counting in the builder. If git in the future supports cloning via commitish we can further simplify the logic.

readme changes

hotfix for 4.7.0 changes which are on develop, will require a second PR from develop into master along the release of 4.7.0.

adamretter commented 5 years ago

You could use a smaller depth. Travis for example uses 50 For CI

duncdrum commented 5 years ago

yes but travis doesn t promise build by COMMIT. Since the docker file covers all minor and patch releases, and potentially even major relases i went big. If you don't build by commit you don't notice the difference anyways.