search

eXist-db / docker-existdb

Docker image builder for eXist-db
GNU Affero General Public License v3.0
11 stars 6 forks source link

build.sh redundant code #8

Closed grantmacken closed 6 years ago

grantmacken commented 6 years ago

Took a quick look at build.sh I think this could do with a bit of a clean up. It is now used inside docker, so stuff like

# Either get or update from GitHub eXist-db

is redundant. Most likely, build.sh could be removed all together, with everything going into the build target.

adamretter commented 6 years ago

I will have to leave @duncdrum to comment on this. As I am still not quite clear how the build process works now

duncdrum commented 6 years ago

hi welcome @grantmacken see #5, build.sh does a number of things right now, and is already used in one of the build stages. The main thing being modification of configuration files (i think there might be more modifications down the line we might want to do). The other stuff such as tagging the image, etc should go into hooks/build, which removes a dependency for folks cloning the repo.

And yes more cleanup is always welcome, the more we can move into the dockerfile the better

grantmacken commented 6 years ago

20 build.sh process logic now in Dockefile