Also test against Java 17

[adamretter]

Test against the version of Java for eXist-db 6.x.x (Java 8), and eXist-db 7.x.x (Java 17).

Requires https://github.com/eXist-db/documentation/pull/904 to be merged first.

[joewiz]

@adamretter With #904 merged, this is ready for a rebase.

[adamretter]

@joewiz Okay I have rebased.

Unfortunately I am now seeing a failure that is unrelated to this PR, which seems to be related to formatting of content of the documentation. I am not sure where that came from. The failure is this:

[INFO] --- frontend-maven-plugin:1.12.1:npm (mocha tests) @ exist-documentation ---
[INFO] Running 'npm test' in /home/runner/work/documentation/documentation
[INFO] 
[INFO] > exist-documentation@6.1.1-SNAPSHOT test
[INFO] > mocha src/test/mocha/ --recursive --exit
[INFO] 
[INFO] 
[INFO] 
[INFO]   running XQsuite test …
[INFO] response body: {"testsuite":{"package":"http://exist-db.org/xquery/documentation/tests","timestamp":"2023-03-20T14:53:11.759Z","tests":"6","failures":"1","errors":"0","pending":"1","time":"PT3.788S","testcase":[{"name":"Listing consistency","class":"tests:equal-listing"},{"name":"section-headings","class":"tests:missing-id"},{"name":"Pro angular brackets","class":"tests:no-ecaped-listings","failure":{"message":"assertEmpty failed.","type":"failure-error-code-1"},"output":"urlrewrite.xml"},{"name":"wellformed xml","class":"tests:no-txt-xmls","pending":null},{"name":"diagnose listings","class":"tests:orphan-listing"},{"name":"ToC rendering","class":"tests:toc-inline"}]}}
[INFO]         6 xqsuite tests:
[INFO]           Listing consistency
[INFO]           section-headings
[INFO]           [ 'Pro angular brackets', 'assertEmpty failed.' ]

I am afraid that I have absolutely no idea what that is or what is meant by 'Pro angular brackets', 'assertEmpty failed.'. It looks like something to do with something called Mocha (JavaScript?)... Any ideas?

[duncdrum]

@adamretter these test failures were introduced by #872 which you cleaned up

see #928

[adamretter]

@adamretter these test failures were introduced by https://github.com/eXist-db/documentation/pull/872 which you cleaned up

@duncdrum Possibly, yes. But I have no idea what these errors mean or how to fix them. There simply isn't enough information... do you know?

[duncdrum]

@adamretter see #928 the XQS test returns the list of documents, where xml as string literal appears inside <programlisting>. The author guidelines contain a section of why this isn't a good idea.

[adamretter]

@joewiz I was in the middle of working on addressing this as @duncdrum had requested... what happened?

[joewiz]

@adamretter I didn't close it directly. I think it was closed automatically when I merged https://github.com/eXist-db/documentation/pull/929. That PR contained a commit whose commit message stated:

fix(ci): add J17 cleanup automatically

close https://github.com/eXist-db/documentation/pull/905

[adamretter]

@duncdrum I am confused why you asked me to do this work, and then you simultaneously did it yourself? Seems we have duplicated and wasted time and effort here :-(

[duncdrum]

@adamretter the Java 17 changes are unrelated to the faulty programmlistings which @joewiz fixed in the meantime.

[duncdrum]

I didn't mean to cause duplicate work.