search

eXist-db / e2e-core

"Integration tests for exist-db auto-deploy applications"
3 stars 2 forks source link

Fix failing build due to Dashboard 2.0 #8

Closed joewiz closed 5 years ago

joewiz commented 5 years ago

As the result of switching to Dashboard 2.0 in develop (#2423) and develop-5.0.0 (#2438), the tests in dashboard_spec.js and users_spec.js now fail.

For the failed test runs, see https://travis-ci.com/eXist-db/e2e-core/jobs/187293781 and https://dashboard.cypress.io/#/projects/w23pgu/runs/83/specs.

To fix the failing tests, I believe we need to account for the following changes:

Also, please bear in mind that the PRs above switching eXist to Dashboard 2.0 affect only the 5.x branches, and the 4.x branch is not (yet) affected. (I say "yet" because we've discussed the idea of switching 4.x to Dashboard 2.0 assuming we encounter no major issues under 5.x. This is an attractive idea given that Dashboard 1.x has many known bugs and is no longer maintained. So for the users who must stay on 4.x, Dashboard 2.0 should be a major improvement.)

@duncdrum I would greatly appreciate any help you might be able to provide with this!

duncdrum commented 5 years ago

@joewiz see #1, over here we can have a minimal test for dashboard by mimicking the existing test for package-manager.

Unless there are problems with our sauce-lab account, @JoernT and @windauer have implemented their own integration tests for polymer2 apps, you ll have to ask them.

joewiz commented 5 years ago

@duncdrum Thanks for the pointers. Since cypress.io can't access the shadow dom for tests, am I right that the "minimal test" you're suggesting would be limited to checking for, say, a 200 response to a request for the landing page?

@JoernT @windauer Could you point me to the integration tests you've implemented for Dashboard?

joewiz commented 5 years ago

@JoernT @windauer I've put Dashboard 2.0 on the agenda for tomorrow's community call, so if you're available, that could be a good opportunity to discuss any last issues before Dashboard 2.0 is included in the next eXist 5.x RC.

JoernT commented 5 years ago

I do not have any tests for the dashboard apps. Yes, that's a shame but results from the fact that i started early with Web Components where technologies were still in flux and i lacked time to work into the WCT back then. Building the apps was a hell lot of work and i was happy to get through anyway.

However of course would be great to add them. WCT btw works fine and of course with ShadowDOM support and there's a script to run them from commandline (e.g. for Jenkins integration). The recipe is found in tei-publisher repo.

joewiz commented 5 years ago

@JoernT Thanks for letting us know!