search

eXist-db / existdb-ansible-role

Ansible role for eXist-db
GNU Lesser General Public License v2.1
11 stars 10 forks source link

[bug] Is `exist_confxml_from_template` production ready? #52

Open adamretter opened 1 year ago

adamretter commented 1 year ago

The README.md for this project states:

exist_confxml_from_template: no

Whether to create certain config files from templates. Not fully supported for conf.xml and web.xml, leave that disabled!

Additionally the defaults/main.yml file states:

# XXX these are not fully supported yet, leave as is! exist_confxml_from_template: no

However, it appears that this option has been set to yes in certain production systems that we have inherited. So I am wondering of the documentation is out of date, or that this should not actually be used in a production system?

Additionally if I search through this Ansible code, it appears to me that all exist_confxml_* settings will actually be ignored unless exist_confxml_from_template: yes is set. Is that the case?

chakl commented 1 year ago

Means "leave this disabled unless you know what you are doing"

all existconfxml* settings will actually be ignored unless exist_confxml_from_template: yes is set.

yes

adamretter commented 1 year ago

So the documentation is incorrect. I will send a Pull Request to fix this...