search

eXist-db / existdb-saml

XQuery module that implements SAML v2 single sign-on
GNU Lesser General Public License v2.1
4 stars 3 forks source link

[BUG] Multiple instances of != #15

Closed adamretter closed 11 months ago

adamretter commented 1 year ago

The XQuery code contains multiple usages of the != operator for string comparison. This is incorrect, instead:

  1. For Atomic Values $x ne $y should be used
  2. For Sequences not($x = $y) should be used

The != operator rarely is the correct operator to use in XQuery, and almost always not what the developer intended.

chakl commented 1 year ago

@adamretter Thanks for your important bug reports!

I'm fully aware of this and have this scheduled for a code review. For now. it surprisingly does what the developer intended. There is no urgent need to fix this "bug", other than general code review.

chakl commented 1 year ago

closing

adamretter commented 1 year ago

I think we should leave this open until it's fixed. I'm happy to send a PR, I normally open issues before sending fixes in PRs