search

eXist-db / monex

Monitoring Application for eXist-db
GNU Lesser General Public License v2.1
6 stars 19 forks source link

Investigate issues with v3.0.5 release, prepare v3.0.6 #217

Closed joewiz closed 1 year ago

joewiz commented 1 year ago

v3.0.5 was released but the pom.xml file still reads 3.0.5-SNAPSHOT, and release notes are missing.

We should investigate what happened with this release and then prepare a new version with release notes and an updated pom, etc.

adamretter commented 1 year ago

@joewiz The pom.xml file should now be correct in master, I simply hadn't finished the process by time you wrote the issue ;-)

The release was cut from a hotfix branch that has its own pom.xml file which was already correct - https://github.com/eXist-db/monex/tree/hotfix-3.0.5

Regards the release notes in the xar-assembly.xml, I was not aware of those. Are they meant to be auto-generated? If not, we should probably document what the release process is for Monex in the README.md. As otherwise a developer who is unaware of any manual steps that are needed needed (like myself), will see a Maven project and run the standard Maven commands to do a release, i.e. mvn release:prepare && mvn release:perform

line-o commented 1 year ago

The tests do not pass. There is one failing cypress test. Also the changes were merged by the committer by the looks of things. That is alarming even if it is just a very small change.

line-o commented 1 year ago

Why was there a release from a hot fix branch in the first place? Is this release compatible with older versions of exist, since this version already includes the update to slf4japi?

line-o commented 1 year ago

related issue https://github.com/eXist-db/exist/pull/4622

adamretter commented 1 year ago

The tests do not pass. There is one failing cypress test.

The tests were failing due to an unrelated reason to these changes. The reason that they failed is that there was a bad Docker image for the latest tag that was being downloaded. I fixed that by uploading the correct Docker image to Docker Hub.

adamretter commented 1 year ago

Why was there a release from a hot fix branch in the first place?

That is the only way you can create a hotfix release after the main branch has moved on from the previous release tag!

Is this release compatible with older versions of exist, since this version already includes the update to slf4japi?

Yes. The hotfix release does not include the update to slf4japi - please check the commit history of the tag if you are uncertain about that.

duncdrum commented 1 year ago

The tests do not pass. There is one failing cypress test.

The tests were failing due to an unrelated reason to these changes. The reason that they failed is that there was a bad Docker image for the latest tag that was being downloaded. I fixed that by uploading the correct Docker image to Docker Hub.

How was that? The images are automatically updated from develop. How was the image bad? Could you just have triggered the deploy step on ci, or did you need to do something else ?

adamretter commented 1 year ago

How was that?

@duncdrum I don't know how it got into the bad state

line-o commented 1 year ago

@adamretter will we know if it gets into a bad state again?

duncdrum commented 1 year ago

@joewiz after the most recent merges, I think we are ready for 3.0.6 which should run on both 5.x and 6.x

joewiz commented 1 year ago

Superseded by #210 and #230.