eXist-db / monex

Monitoring Application for eXist-db
GNU Lesser General Public License v2.1
6 stars 20 forks source link

Node bump #223

Closed duncdrum closed 1 year ago

duncdrum commented 1 year ago

close #222

bumps node to 18, lots of vulnerability fixes, more could be done, but I think this is fit for a maintenance release. Could be a major release, as we are deprecating older versions of node during build time.

P.S.: once this is merged we should check #215

duncdrum commented 1 year ago

@line-o mind taking a look and merging?

line-o commented 1 year ago

The version has to be 4.0.0-snapshot as the processor version must be 6.1.0 because of slf4japi version is now v2

line-o commented 1 year ago

See my open PR

duncdrum commented 1 year ago

@line-o ok I see, however, the changes to slf4japi are unrelated to the changes in this PR. The version bump should have been made with those earlier PRs.

If we bump the processor dependency now, without a published jar file, we can no longer compile monex, or create releases from the main branch. Which leaves us two options:

I don't really care which way, having a security release would probably be nicest for users.

I have no idea where I can find the exist.java-api.version not sure if we're in lockstep or if it needs to change from 5.4.0