search

eXist-db / shared-resources

An app package with shared resources used by several eXist-db applications
5 stars 16 forks source link

[BUG] Usage of deprecated and removed `git://` protocol #53

Open DrRataplan opened 1 week ago

DrRataplan commented 1 week ago

Describe the bug This repo uses the deprecated git:// protocol in the README and in the git submodules (and the submodules of the submodules).

Expected behavior

  1. The whole repository can be recursively checked out.

To Reproduce

  1. run git clone git://github.com/eXist-db/shared-resources.git /tmp/shared-resources --recursive
  2. Wait

Context (please always complete the following information): Not relevant

Additional context The git:// protocol is deprecated and removed. In 2022. https://github.blog/security/application-security/improving-git-protocol-security-github/#no-more-unauthenticated-git.

The upstream ace submodule fixed this: https://github.com/ajaxorg/ace/commit/69edbf946058365345d27886464ed8fe462de944. This is released a few patch versions higher than the current version. We're now somewhere between 1.1.3 and 1.1.4, this is released as part of 1.1.7.

I am trying to locally clone this app so I can locally deploy a very old ExistDB app (currently on 5.2.0). I will remove the usage of shared-resources, but as a later step to prevent any rabbit holes.

I dont expect a fix. But I'm filing this issue to suggest a workaround to future code archeologists running into the same issue: Workaround: 

# Replace `git://` with `https://` for all clones
git config --global url."https://".insteadOf git://