Pressing Enter in advanced search should not add search fields

[jodevelops]

When hitting the enter button in the advanced search field, three more search fields are added below instead of triggering the search (like in the simple search).

Reproduced in Firefox and Chrome.

[claudius108]

Hi,

I fixed this on the Tamboti test server.

Would you be so kind to check it, and tell if the current behaviour is what you were looking for?

Thanks, Claudius

[jensopetersen]

Yes, this works great, but when you press Enter in Simple Search, the interface shifts to Advanced Search. The query-tabs param are probably set to "advanced-search-form", but should be set to "simple" (cf. search-form.html). I had thought of cleaning up these values, changing "simple" to "simple-search-form" ….

[claudius108]

Fixed, thanks for pointing it.

[jensopetersen]

Great!

Could you send a pull request?

[claudius108]

Hm,

Says: "These branches can be automatically merge", and the button "Send pull request" is not activated.

Claudius

On Mon, Nov 11, 2013 at 11:18 AM, Jens Østergaard Petersen < notifications@github.com> wrote:

Great!

Could you send a pull request?

— Reply to this email directly or view it on GitHubhttps://github.com/eXist-db/tamboti/issues/37#issuecomment-28187854 .

http://kuberam.ro http://kuberam.ro/art

[jensopetersen]

We do not merge our own commits.

In your local repo you should click on "Pull Requests" and then "New Pull Request".

[claudius108]

Yes, that message appears when I click "New Pull Request".

Claudius

On Mon, Nov 11, 2013 at 11:29 AM, Jens Østergaard Petersen < notifications@github.com> wrote:

We do not merge our own commits.

In your local repo you should click on "Pull Requests" and then "New Pull Request".

— Reply to this email directly or view it on GitHubhttps://github.com/eXist-db/tamboti/issues/37#issuecomment-28188404 .

http://kuberam.ro http://kuberam.ro/art

[jensopetersen]

Have you written a description? Click in the description field and write something ….

[claudius108]

Did it already, it is not enabling the button.

On Mon, Nov 11, 2013 at 11:51 AM, Jens Østergaard Petersen < notifications@github.com> wrote:

Have you written a description? Click in the description field and write something ….

— Reply to this email directly or view it on GitHubhttps://github.com/eXist-db/tamboti/issues/37#issuecomment-28189553 .

http://kuberam.ro http://kuberam.ro/art

[jensopetersen]

Hmm, then I don't know …. Could you try to clone the repo again?

I would like to release a new distribution today, so could you send the file to me?

[claudius108]

Attached; search-form.html is from tamboti theme.

Claudius https://mail.google.com/mail/u/0/?ui=2&ik=b51eefc33a&view=att&th=14246e83ebbfceb2&attid=0.1&disp=safe&realattid=f_hnvmjcpw1&zw

On Mon, Nov 11, 2013 at 12:18 PM, Jens Østergaard Petersen < notifications@github.com> wrote:

Hmm, then I don't know …. Could you try to clone the repo again?

I would like to release a new distribution today, so could you send the file to me?

— Reply to this email directly or view it on GitHubhttps://github.com/eXist-db/tamboti/issues/37#issuecomment-28190896 .

http://kuberam.ro http://kuberam.ro/art

[claudius108]

But I guess that the id for form should be added to all themes.

Claudius

On Mon, Nov 11, 2013 at 12:25 PM, Claudius Teodorescu < claudius.teodorescu@gmail.com> wrote:

Attached; search-form.html is from tamboti theme.

Claudius https://mail.google.com/mail/u/0/?ui=2&ik=b51eefc33a&view=att&th=14246e83ebbfceb2&attid=0.1&disp=safe&realattid=f_hnvmjcpw1&zw

On Mon, Nov 11, 2013 at 12:18 PM, Jens Østergaard Petersen < notifications@github.com> wrote:

Hmm, then I don't know …. Could you try to clone the repo again?

I would like to release a new distribution today, so could you send the file to me?

— Reply to this email directly or view it on GitHubhttps://github.com/eXist-db/tamboti/issues/37#issuecomment-28190896 .

http://kuberam.ro http://kuberam.ro/art

http://kuberam.ro http://kuberam.ro/art

[jensopetersen]

You did make a pull request some days ago ….

Anyway, the file did not come through (link gives 404), so please resend. I will change in the other search forms.

[jensopetersen]

Never mind - I will just apply the code from your commit to your own repo.

[jensopetersen]

If you just commit the files to your own repo, I could "pull" them off from there. The last commit is three days old.

[jensopetersen]

Fixed by Claudius with Tamboti 1.1.1.