Several small fixes - Githubissues

eXist-db / templating

HTML Templating Library for eXist-db

GNU Lesser General Public License v2.1

5 stars 8 forks source link

Several small fixes #6

Closed adamretter closed 3 years ago

adamretter commented 3 years ago

Website was wrong
Required eXist-db version was wrong
Library Module had wrong filename

joewiz commented 3 years ago

@adamretter I'm curious, what's the basis of the requirement for 5.2.0?

adamretter commented 3 years ago

Previously the README.md said that you need 5.x, but that's not a concrete version or a version pattern. So I just chose a version that was above 5.0.0 that I think is relatively stable

joewiz commented 3 years ago

Thanks. Ok, the PR looks good to me.

joewiz commented 3 years ago

p.s. I also support adopting the convention to use xqm as the file extension of library modules, especially in new projects.

adamretter commented 3 years ago

Thanks Joe. It's actually a convention I sought agreement on years ago. I then published it in the eXist-db book. Some have kept to it