bugfixes: user account update, create user

eXist-db / usermanager

Rewrite of the original eXist-db user manager

GNU Lesser General Public License v2.1

2 stars 3 forks source link

bugfixes: user account update, create user #32

Open tuurma opened 5 years ago

tuurma commented 5 years ago

solves eXist-db/dashboard#93 and eXist-db/dashboard#76

adamretter commented 5 years ago

@tuurma I took a look over your PR, thanks for that :-)

It looks good, but as far as I can see, it doesn't solve eXist-db/dashboard#93 as claimed. Thoughts?

joewiz commented 5 years ago

On Monday's Community Call @duncdrum suggested that fixing this issue would be a good opportunity to review https://github.com/eXist-db/usermanager/pull/25 (a PR which moves the Cypress integration tests into this repository), update it to reflect the recent changes to the login behavior, and to add a test showing that the fix to this issue has the expected results.

tuurma commented 5 years ago

@adamretter correct, didn't read the exist-db/dashboard#93 title properly: there were two parts to that issue

updating the user in any way was failing (now fixed)
resulting 500 error (now replaced with a similar problem with a login redirect)

currently working on proper fix for the second part

tuurma commented 5 years ago

@joewiz Thanks, I do realise that it would be ideal to add relevant tests asap