Closed line-o closed 9 months ago
I tested this fix locally by setting up an instance that has REST disabled. There is no automated test for this at the moment because do not know how to do this in docker yet. @duncdrum help would be appreciated as there will be more REST API used in the future. @luckydem This is the fix for the issue you reported.
@line-o I would create another workflow file, not use services
but modify and assemble the image on the ci server like we do for most stock apps. Basically:
conf.xml
into image@duncdrum Would you be able to share a link to an example?
and
the run
keyword in the bats test need to be run:
in gha yml. docker …
is just the docker command you want to execute
How do we maintain modified configurations for each version of exist that is currently in the testmatrix?
matrix expansion in the yaml file, something like
docker pull duncdrum/existdb:${{ exist.version }}-j8
@duncdrum shouldn't it be more like
sed
for example)You can do that, it ll take long to run though. As you need a running container for the copy (I think that’s still the case) If you want to do this I would download them from the containers in the unit test phase, and share as artefact or even commit to repo.
Once you commit to repo, you might as well store the changes files and maintain these by hand. Either way works.
:tada: This PR is included in version 1.9.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
fixes #170
Try REST connection, fall back to XMLRPC and inform user that this happened.