eXpandFramework / eXpand

DevExpress XAF (eXpressApp) extension framework. 𝗹𝗶𝗻𝗸𝗲𝗱𝗶𝗻.𝗲𝘅𝗽𝗮𝗻𝗱𝗳𝗿𝗮𝗺𝗲𝘄𝗼𝗿𝗸.𝗰𝗼𝗺, 𝘆𝗼𝘂𝘁𝘂𝗯𝗲.𝗲𝘅𝗽𝗮𝗻𝗱𝗳𝗿𝗮𝗺𝗲𝘄𝗼𝗿𝗸.𝗰𝗼𝗺 and 𝘁𝘄𝗶𝘁𝘁𝗲𝗿 @𝗲𝘅𝗽𝗮𝗻𝗱𝗳𝗿𝗮𝗺𝗲𝘄𝗼𝗿𝗸 and or simply 𝗦𝘁𝗮𝗿/𝘄𝗮𝘁𝗰𝗵 this repository and get notified from 𝗚𝗶𝘁𝗛𝘂𝗯
http://expand.expandframework.com
Microsoft Public License
220 stars 114 forks source link

Combination of CloneModelView and ModelMergedDifferences attributes does not work #601

Closed krombipils closed 4 years ago

krombipils commented 4 years ago

Here is a simple demo combining CloneModelView and ModelMergedDifferences attributes on a Business Object.

cloned

No MergedDifferences node is generated in TestBO_Cloned_DetailView and therefore no inheritance is applied. If I add the MergedDifferences manually to the xafml, everything is fine.

Solution1.zip

expand commented 4 years ago

The DevExpress.XAF repository includes commits that relate to this task:

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.

If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.

Thanks a lot for your contribution.

krombipils commented 4 years ago

Really would like to test the new version, but I think you have to bump eXpand versions again?! The dependencies/versioning probs are somehow/sometimes a pain in the ass

apobekiaris commented 4 years ago

yeah the update is still a bit manual but I am working to automate this bumping as well

expand commented 4 years ago

eXpand.lab release 19.1.701.4 includes commit that relate to this task:

  1. CloneModelView: Keep ModelNodeGenerators #601
  2. ModelMapper: IModelLayoutGroup Caption is incorrect #596](https://github.com/eXpandFramework/eXpand.lab/commit/a0148d801f29ae112adfdb2d281fabb87f1773a1)

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.

Thanks a lot for your contribution.

expand commented 4 years ago

eXpand.lab release 19.1.701.8 includes commit that relate to this task:

  1. CloneModelView: Keep ModelNodeGenerators #601
  2. ModelMapper: IModelLayoutGroup Caption is incorrect #596](https://github.com/eXpandFramework/eXpand.lab/commit/a7fe51aca9d529a41382d4c91149c5e9a83164a2)

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.

Thanks a lot for your contribution.

krombipils commented 4 years ago

Thank you, but with the new version it is now no longer possible to use ModelViewInheritance if view is cloned in model editor. I attached my modified sample project. Instead of using the atributes I added this to my model.designeddiffs.xafml:

<DetailView Id="TestBO_Cloned_DetailView" ClassName="Solution1.Module.BusinessObjects.TestBO" IsNewNode="True">
  <MergedDifferences IsNewNode="True">
    <MergedDifference Id="@2f13170e-008a-4661-9058-57a940a38362" View="TestBO_DetailView" IsNewNode="True" />
  </MergedDifferences>
</DetailView>

Now an exception is thrown on startup: grafik Solution1.zip

expand commented 4 years ago

The DevExpress.XAF repository includes commits that relate to this task:

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.

If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.

Thanks a lot for your contribution.

krombipils commented 4 years ago

Latest lab nuget version 1.0.14.4 does not contain this patch/commit.

apobekiaris commented 4 years ago

for start plan is to publish releases in the DevExpress.XAF repo containing the only the changed nupkg files.

expand commented 4 years ago

eXpand.lab release 19.2.300.16 includes commit that relate to this task:

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.

Thanks a lot for your contribution.

expand commented 4 years ago

Closing issue for age. Feel free to reopen it at any time.

.Thank you for your contribution.