modelassembly.dll always recreated.

Johnka2 commented 2 years ago

Steps.

create new xaf solution
Add eXpandMasterDetailWin to module project and register it
Run application multiple times even in release mode 4.modelassembly.dll is always recreated.

Expected behavior Modelassembly.dll should be generated ounce.

Startup noticeably slow for large models.

Kagandaj commented 1 year ago

Issue could be caused by Xpand.ExpressApp.MasterDetail.MasterDetailModule and Xpand.XAF.Modules.MasterDetail.MasterDetailModule
having the same type name. Renaming one stopped the problem for me in production

apobekiaris commented 1 year ago

Sample applicati9on please

Kagandaj commented 1 year ago

going thru @Johnka2 steps reproduces the problem for .net6 i renamed Xpand.ExpressApp.MasterDetail.MasterDetailModule to Xpand.ExpressApp.MasterDetail.GridMasterDetailModule to remove the naming conflict in the moduleinfo file at runtime and compiled the module. moduleassembly.dll isn't recreated every time in release mode anymore.

another workaround would be to remove the Xpand.ExpressApp.MasterDetail.MasterDetailModule from the application

apobekiaris commented 1 year ago

i renamed Xpand.ExpressApp.MasterDetail.MasterDetailModule to Xpand.ExpressApp.MasterDetail.GridMasterDetailModule

I cannot follow where is the conflict?

Kagandaj commented 1 year ago

look at these two modules Xpand.ExpressApp.MasterDetail.MasterDetailModule Xpand.XAF.Modules.MasterDetail.MasterDetailModule

they have the same type name "MasterDetailModule" at runtime when a xaf application starts it examines ModulesVersionInfo file. since the two modules are versioned differently xaf thinks that the version has changed for one of these modules. remember the ModulesVersionInfo does not use full type names. as a result modelassembly.dll will always be regenarated. A solution would be to rename one of these modules

apobekiaris commented 1 year ago

aha I agree we may have issues there I will rename, thnks!

apobekiaris commented 1 year ago

The pre-release 4.222.14.0 in the Reactive.XAF lab branch includes commits that relate to this task:

Rename MasterDetailModule #900

To minimize version conflicts we recommend that you use the Xpand.XAF.Core.All, Xpand.XAF.Win.All, Xpand.XAF.Web.All packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).

Released packages:

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.

If you do not use these packages directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.

Thanks a lot for your contribution.

expand commented 8 months ago

Closing issue for age. Feel free to reopen it at any time.

.Thank you for your contribution.

eXpandFramework / eXpand

modelassembly.dll always recreated. #900