ArgumentException if using MiddleTierServerObjectSpaceProvider and Reactive.XAF-Modules

krombipils commented 2 years ago

Hi,

if using the DevExpress.ExpressApp.Security.ClientServer.MiddleTierServerObjectSpaceProvider in combination with any Reactive.XAF module, an ArgumentException: "Bad label content in ILGenerator" is thrown (and shown to the user) before the login dialog is opened.

grafik

The error occurs in the ObjectSpaceProviderExtensions.PatchSchemaUpdated method.

I attached a simple project to demonstrate the problem. This solution was created by the DevExpress XAF 21.2.7 wizard. I just added the HideToolbarModule manually (but any other Reactive.XAF module will trigger the same error).

Unfortunately I have no clue what's going wrong.

DXApplication8.zip

apobekiaris commented 2 years ago

note these event are not used from any package they are there for convenience to external consumers, as so I will simply disable the MiddleTier support.

apobekiaris commented 2 years ago

Unfortunately I have no clue what's going wrong.

I also not have any clue cause Harmony is really robust when applied to non virtual method of any visibility, My guess is that it relates how compiler transaltes the provider UpdateScheme native implementation

public void UpdateSchema() => throw new NotSupportedException();

apobekiaris commented 2 years ago

The pre-release 4.212.9.0 in the Reactive.XAF lab branch includes commits that relate to this task:

MiddleTierServerObjectSpaceProvider cannot be patched #934

To minimize version conflicts we recommend that you use the Xpand.XAF.Core.All, Xpand.XAF.Win.All, Xpand.XAF.Web.All packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).

Released packages:

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.

If you do not use these packages directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.

Thanks a lot for your contribution.

krombipils commented 2 years ago

Problem is fixed in 4.212.9.7. Thank you!

apobekiaris commented 2 years ago

how about this version??

internal static IObservable<Unit> PatchAuthentication(this XafApplication application) 
            => application.WhenSetupComplete()
                .DoWhen(_ => application.Security.IsInstanceOf("DevExpress.ExpressApp.Security.SecurityStrategyBase"),
                    _ => application.Security.GetPropertyValue("Authentication").GetType().Methods("Authenticate")
                        .Last(info => info.DeclaringType is { IsAbstract: false })
                        .Patch(new HarmonyMethod(typeof(SecurityExtensions),nameof(Authenticate))))
                .ToUnit();

and the Patch extension which always avoid double attempts

        public static Harmony Patch(this MethodInfo method, HarmonyMethod prefix = null, HarmonyMethod postFix = null, HarmonyMethod transpiler = null)
            => AppDomain.CurrentDomain.Patch(harmony => {
                if (harmony.GetPatchedMethods().All(m => m!=method)) {
                    harmony.Patch(method, prefix, postFix, transpiler);
                }
            });

how hard it is to test it since u there already?

krombipils commented 2 years ago

Give me a few minutes

krombipils commented 2 years ago

Your code is working fine. Unfortunately I cannot say anything about the performance on Azure, but at least I don't see any exceptions. The new version always creates a new HarmonyMethod instance (even if not required, because patch was already applied). I don't know if this is a (performance) problem. I guess we could instead pass a methodName and a Func returning the HarmonyMethod(), but no idea if this is really a better solution:

    public static Harmony Patch(this MethodInfo method, string patchName, Func<HarmonyMethod>? prefix = null,
        Func<HarmonyMethod>? postFix = null,
        Func<HarmonyMethod>? transpiler = null)
        => AppDomain.CurrentDomain.Patch(harmony =>
        {
            if (harmony.GetPatchedMethods().All(m => m.Name != patchName))
            {
                harmony.Patch(method, prefix?.Invoke(), postFix?.Invoke(), transpiler?.Invoke());
            }
        });

apobekiaris commented 2 years ago

i was afraid it might fail although it shouldn't, cannot put more energy on this though I will check against the name, however name can be doubles that why I attempted the metadata check. In any case I think we are fine we not a patch factory

apobekiaris commented 2 years ago

The pre-release 4.212.9.0 in the Reactive.XAF lab branch includes commits that relate to this task:

AppDomain Patch to MethodInfo patch #934

To minimize version conflicts we recommend that you use the Xpand.XAF.Core.All, Xpand.XAF.Win.All, Xpand.XAF.Web.All packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).

Released packages:

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.

If you do not use these packages directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.

Thanks a lot for your contribution.

eXpandFramework / eXpand

ArgumentException if using MiddleTierServerObjectSpaceProvider and Reactive.XAF-Modules #934