search

eXparity / hamcrest-date

A Java library which provides a suite hamcrest matchers for matching dates, times, and moments in time
BSD 3-Clause "New" or "Revised" License
70 stars 11 forks source link

Matchers for Joda-Time temporals #23

Open tnaskali opened 5 years ago

tnaskali commented 5 years ago

Support for Joda-Time LocalDate, LocalDateTime, LocalTime and DateTime (compile-only non-transitive dependency to joda-time)

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.2%) to 85.88% when pulling b08b369afa439dd97f3a3b56fe356287033f8c40 on tnaskali:master into cb337b094b21ba63b77356871434dddd010678c2 on eXparity:joda-time.

stewbis commented 5 years ago

This library is for core java types only and not joda time. I'd recommend creating a new library called hamcrest-joda-time to host the joda time matchers.

tnaskali commented 5 years ago

This seems like a better option indeed. What about creating a "core" generic library and two implementations that depend on it, java and joda-time ?

stewbis commented 5 years ago

Hi, really sorry for not getting back sooner and yes the split to a core lib with java and joda implementations may make sense. Before the split though - are you able to raise a PR or create a branch of master with just the changes to support Joda so I can see the extent of the change. This PR contains all the changes for the zone change as well so it's hard to see the scope of the change. If the change looks clean I can look at doing the split in a branch. Regards, Stewart

tnaskali commented 5 years ago

Hi Stewart, I tried to package all the code to support Joda under the org.exparity.hamcrest.date.joda package. All the other changes should be related to time zone support. In the meantime I'll try to split them into two separate branches / PRs. Thomas

stewbis commented 5 years ago

Hi Thomas, If it's all under the org.exparity.hamcrest.date.joda package then that's cool. I'll pull the PR down and review the diff. No need for you to split it out.

stewbis commented 5 years ago

I've re-opened the PR but into a new branch called joda-time.