Basic project listing

[eXpl0it3r]

Implement a basic project listing, which means implementing the Model and very basic Controller.

This way we can start to see what this project is all about, having a list of projects.

[ghost]

Implemented in 'feature/project_list' branch

[ghost]

Well, the other types of listing is done. Also added non-square thumbnails to take a look, how it will be look like.

[zsbzsb]

I looked over the branch and figured I would comment here.

1. Is there a reason you set the title of the Projects page twice?
2. Translations, we were putting pages into the pages table as a way to reduce time spent writing templates and as an easier way to provide page translations. So should the three links used to switch between the 3 project views be moved into the database?
3. Is /public/user_data/projects/ where we want to store the uploaded data?
4. The formatting in /public/assets/css/custom.css doesn't match existing formatting. Mainly the colons do not line up.
5. The projects are only highlightable/clickable in the compact view, don't we want the project listing to respond to the mouse in all 3 views?

Other than the points I mentioned above it looks good to me, but I am sure @eXpl0it3r will have other comments. Also if I am saying something stupid please ignore my pointless rambling.

[ghost]

@zsbzsb, I've fixed 1, 4 and 5 points.

For the place to store uploaded data in - it is just my suggestion ;) And about translations. If I'll put in into 'pages' table - it would be hard to implement highlighting currently selected listing mode.

[ghost]

But I can do listing modes like navbar by creating table with all the listing modes https://github.com/eXpl0it3r/SFMLProjects/blob/dev/application/classes/Controller/Layout.php#L71

[zsbzsb]

The updated commit looks good to me concerning the points that were fixed. :smile:

[eXpl0it3r]

Finally get around to look at this! The result is really nice, good job! :smiley:

• We have an automatic view loader in the layout controller, it will automatically load a view class in the form of View_Controller_Action, as such the View_Projects_View should be renamed to View_Projects_List, including the filename and the = new View_Projects_View; isn't needed anymore.
• A controller should never hold any kind of HTML code. The goal of a MVC framework is to separate the controlling code (controller) from the displaying bits (view). You should move the list into a template. Since it's always the same code you can make use of a partial template, for example something like this: {{>list_types}} and then have a file templates/partials/list_types.mustache.
• Alternative to the whole active code blocks, you could just create an array of three entries, which each hold the fields active, url and name or similar, then all you need to do in the template is {{#list_types}}<li {{#active}}class="active"><a href="{{url}}">{{name}}</a></li>{{/list_types}}.
• For the model it might be a good idea to keep the returned data similar across all models, meaning return arrays or objects. Personally I like objects since it's easier to type -> than ['key'], but I'm open for suggestions.
• Just as a note: Sometime in the future we'll be serving the user_data via PHP as well.

Let me know if you want to do the changes or if I should. :wink: When things are adjusted feel free to make pull request.