eXpl0it3r / Schiffbruch

Schiffbruch is a mix of building, strategy and adventure and gets played with a two-dimensional view.
Other
74 stars 11 forks source link

WIP fixed #11

Open sandsmark opened 3 years ago

sandsmark commented 3 years ago

included the english translation, ported away from directx stuff (uses sfml for everything), switched to embedding the resources (images and sounds) so it doesn't have to be run from the bin directory, and some other stuff (translating stuff in the source from german to english etc.)

seems to work well enough here on linux, but it's still a bit messy

eXpl0it3r commented 3 years ago

Haven't really commented on this so far, as you've been making a lot of updates still.

Awesome work! 🙂

Obviously it's kind of hard to review this huge PR, so I wonder:

sandsmark commented 3 years ago

Obviously it's kind of hard to review this huge PR, so I wonder:

Yeah, I went a bit overboard. :-P

I guess the easiest is just to review the new code as is or something.

  • What are the main changes you've been doing?

Basically just clean everything up. Translated most of the code (and a lot of the comments) from german to english, porting all the graphics stuff from directx to sfml, replaced a lot of windows-specific APIs with cross platform stuff, replaced a lot of defines with enums, cleaning invalid memory stuff, fixed english text in the UI, replaced the loading of game assets (graphics and sound) from the directory the binary is run from with baking them into the executable itself (so you just need the executable to run it, i. e. standalone).

And just a lot of cleaning up the code in general.

  • What are your future plans?

Replacing all the global state with proper classes is probably the next thing I want to do. And in general just making the codebase "modern" and a bit more future proof. I like the game. :-)

FWIW, I made a pkgbuild for archlinux as well and put it on the AUR: https://aur.archlinux.org/packages/schiffbruch-git

SimonHeimberg commented 2 years ago

I was able to compile with cmake on linux after I fixed above problem. Actually this is the same problem as is reported by AppVeyor. A big success for me, since I am not used to compiling.

The game is playable but has some bugs:

thanks for porting this game to all involved