search

eXtensibleCatalog / test

Testing
MIT License
0 stars 0 forks source link

Kyushu Solr enhancements (10 patches) #104

Closed patrickzurek closed 7 years ago

patrickzurek commented 7 years ago

JIRA issue created by: rcook Originally opened: 2012-02-14 03:56 PM

Issue body: (nt)

This issue has an attachment associated with it (external link): xc-6.x-1.1-dec-17-mod.zip

patrickzurek commented 7 years ago

JIRA Comment by user: rcook JIRA Timestamp: 2012-02-14 03:57 PM

Comment body:

Peter agrees with these and have already worked out issues with Kyushu on how to proceed.

Peter, please expand a little, not great detail.

patrickzurek commented 7 years ago

JIRA Comment by user: pkiraly JIRA Timestamp: 2012-03-28 02:46 PM

Comment body:

Here is the message and the file Shin sent me at 2012-01-25.

KATAOKA SHIN

jan. 25.

Hi Peter,

Takashi reported a solution for solr indexing error and I tried to translate (attached). This involves 10 files.

Could you compare delta between the original code base and attached codes, then merge into the original code, although some testing may be needed?

patrickzurek commented 7 years ago

JIRA Comment by user: mwesley JIRA Timestamp: 2012-09-14 02:22 PM

Comment body:

Trying to bring a conclusion to this issue. The patches were not applied directly. Instead, the concepts were applied. Therefore, almost all requested were made. From my review of the modules and patch changes, the only two changes that were not implemented are the following:

Control for performance (Do not execute "ALTER TABLE xxx DISABLE KEYS") Control for performance (Do not execute "ALTER TABLE xxx ENABLE KEYS")

With that stated, I think we can have a short discussion about whether to do the disabling and enabling of keys (while loading data from CSV files) or not. In my opinion, it comes down to developer preference, since whether this actually improves performance or not strongly depends on the way a system administrator configures their MySQL server and disk drives, and also depends on how many records are being harvested.

If there is no clear reason to remove this, I'd prefer to keep it as it is.

patrickzurek commented 7 years ago

JIRA Comment by user: mwesley JIRA Timestamp: 2012-09-23 03:52 AM

Comment body:

I'm marking this as fixed. For the most part, it is. However, the small amount of discussion left, I'm moving to DRUPAL-491.

patrickzurek commented 7 years ago

Issue resolved: 2012-09-23 03:52 AM