search

ea4k / klog

KLog is a multiplatform free hamradio logger. It runs natively on Linux, macOS and Windows.
https://www.klog.xyz
GNU General Public License v3.0
76 stars 25 forks source link

disable keyboardTracking for the frequency input #617

Closed boryszef closed 1 year ago

boryszef commented 1 year ago

Fix the problem, when the number is filled with decimal zeros before the user has finished typing.

boryszef commented 1 year ago

fix #378 #529 #448 #588

ikbenkous commented 1 year ago

This change works on my end and works with #626!

boryszef commented 1 year ago

Another change was merged recently, increasing the precision of the frequency. I have confirmed locally that both changes work together and resolved the conflict accordingly.

ikbenkous commented 1 year ago

@ea4k I believe CI on the master branch broke because of some unrelated merges you did recently. That's probably why this PR is failing checks as well.

Are you aware of that? Or am I mistaken?

ccb1850 was green across the board.

ea4k commented 1 year ago

I merged several PR and code I had in my computer. I didn't want all branches to be too far from each other and I decided to merge.

It was not usual that I had several PR waiting and my time for coding since August has been too short to finish the work I was doing.

The code in master is not finished but I wanted it to be available.

ikbenkous commented 1 year ago

@boryszef I fixed CI on master. You might be able to rebase these commits and retest them out with CI.

ikbenkous commented 1 year ago

This stale PR can now be closed. Changes already merged in #637.

Could we close this one? @ea4k or @boryszef ...