ea4k / klog

KLog is a multiplatform free hamradio logger. It runs natively on Linux, macOS and Windows.
https://www.klog.xyz
GNU General Public License v3.0
75 stars 25 forks source link

Slightly improve frequency handling #626

Closed ikbenkous closed 11 months ago

ikbenkous commented 1 year ago

Set QSO frequency input spinbox precision to 1 Hz to allow manual entry. Change QSO::isSameFreq() comparison to 10 Hz so tuning up or down 100 Hz is detected as freq change.

This should allow better frequency inputs for now.

ikbenkous commented 1 year ago

This should fix #622 and #595. See also: #378

ea5wa commented 1 year ago

I can't see that "improved frequency handling"... I think is better go for another solution as you mentioned, the Frequency class.

ikbenkous commented 1 year ago

@ea5wa This changes how the UI controls work. Users should be able to input frequencies with 1 hertz precision.

Even with a class Frequency, this change is still going to be needed.

ikbenkous commented 1 year ago

@ea5wa

I can't see that "improved frequency handling"...

Right now. You can't enter frequencies that end in something 300 or 500 Hz. After the change, you can. That's what I meant with 'improved handling' btw.