search

eaburns / toaq

Tools for the constructed, logical language Toaq.
8 stars 1 forks source link

Allow precombined breve diacritics, ŏ #9

Closed eaburns closed 5 years ago

eaburns commented 6 years ago

Technically, the falling-rising tone uses a caron. But the old, alpha primer doc used breve, and there are still some breves around in the wild. We should allow these.

Note that we already allow the breve combining character anyway.

eaburns commented 5 years ago

Did you mark the wrong issue as fixed?

I think you need to add both the capital and lower-case versions of the breve characters to the character classes in the rules here: https://github.com/eaburns/toaq/blob/master/ast/toaq.peggy#L482.

eaburns commented 5 years ago

Nevermind. It's just a case of me being inept at understanding the github UI. Somehow when I first clicked on your change, I only saw the first edited file, but not the rest.

eaburns commented 5 years ago

Thanks. This is great.