search

eadmundo / redux-seamless-immutable

Helpers for using seamless-immutable in Redux
MIT License
46 stars 11 forks source link

Remove babel setting in package.json #5

Closed stevenyap closed 7 years ago

stevenyap commented 7 years ago

babel setting in package.json causes TransformError in react-native and expo... many repo do not put the babel setting in package.json

rudolfs commented 7 years ago

👍

eadmundo commented 7 years ago

Hi, thanks for submitting the PR.

I am certainly open to this change, but as it stands currently, the tests are failing (unless you have a .babelrc with the correct preset). I'm not sure what the best practice is here - I don't believe that .babelrc should be checked in, but also we need the tests & the build to work.

The build command we can adjust to be:

rimraf lib && babel --presets es2015 src --out-dir lib

but I haven't yet worked out how to pass that flag to the test command. I can look at again later, but if that's something you could work out that would be great.

eadmundo commented 7 years ago

Perhaps it is acceptable to commit the appropriate .babelrc for an npm module. Perhaps you could add that to the PR and confirm the tests pass? Or I am open to suggestions for how else to resolve it.

raphaeleidus commented 7 years ago

usually .babelrc is checked in as it dictates project settings and not user preference.

eadmundo commented 7 years ago

I agree with @raphaeleidus really