search

eadmundo / redux-seamless-immutable

Helpers for using seamless-immutable in Redux
MIT License
46 stars 11 forks source link

Add state and reducer validation and more tests #7

Closed akread closed 6 years ago

akread commented 7 years ago

This will align the seamless-immutable implementation of combineReducers with the more robust version which comes with redux itself. It includes state/reducer validations and throws errors when things seem awry.

akread commented 7 years ago

@eadmundo take a look at this when you get a chance. They should be some welcome additions to make the library more robust.

akread commented 7 years ago

Hi @eadmundo, just checking in to see if you saw this and if you plan to review it. Let me know if I can help clarify anything.

eadmundo commented 7 years ago

hi @akread - yes to both! I plan to make some time for it early next week.

akread commented 6 years ago

@eadmundo bump – any progress on this?

raphaeleidus commented 6 years ago

@eadmundo Hey I am running this PR in my repo. It is totally stable. Do you think you could merge it and publish to NPM?

akread commented 6 years ago

@eadmundo bump on this again....its been quite a while. Are you planning on reviewing this still? If not please let me know and I'll bring the code I proposed in this PR into my project internally and remove the dependency on this library – we are only using this single function. I have a dependency off my github repo fork right now but we'd like to stop doing that ideally and go off the published package in the npm registry.

eadmundo commented 6 years ago

hi @akread (and @raphaeleidus) - apologies for the delay, just been very busy with the day job :) (which isn't currently involving redux as much). I will review today and get merged.

thanks for bumping!

eadmundo commented 6 years ago

Merged and published v0.4.0 to npm - thanks!